Skip to content

Autocomplete - Uses simple-combobox example#33155

Open
tjshiu wants to merge 2 commits intoangular:mainfrom
tjshiu:autocomplete-top
Open

Autocomplete - Uses simple-combobox example#33155
tjshiu wants to merge 2 commits intoangular:mainfrom
tjshiu:autocomplete-top

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented Apr 27, 2026

  • Updated to simple-combobox: Hooked up the autocomplete examples to use the new simple-combobox patterns and wired in the
  • Added a softDisabled state to default to true
  • Fixed focus management: Swapped out the custom [tabbable] input for standard [tabIndex]="-1"

@tjshiu tjshiu requested a review from ok7sai April 27, 2026 23:43
@pullapprove pullapprove Bot requested review from andrewseguin and crisbeto April 27, 2026 23:43
@tjshiu tjshiu added dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release labels Apr 27, 2026
@github-actions
Copy link
Copy Markdown

Deployed dev-app for 15bf0bf to: https://ng-dev-previews-comp--pr-angular-components-33155-dev-ywds9976.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@ok7sai
Copy link
Copy Markdown
Member

ok7sai commented Apr 27, 2026

I'd suggest adding autocomplete examples with simple combobox to it's own page instead of replacing the current autocomplete, so when we do bug bash we can compare the two examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: aria/combobox dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants